texinfo: fix build references when cross-compiling #178352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XS modules were being built for the build platform, and the perl scripts
had build platform shebangs.
It is possible to build the XS modules by passing
PERL_EXT_CC=${stdenv.cc.targetPrefix}cc and --enable-perl-xs=yes, but they
fail to load due to a handshake key mismatch. Instead, I just decided to
disable the XS modules and use the pure Perl fallbacks when cross-compiling.
The shebangs were fixed manually using substituteInPlace.
texinfo is a nativeBuildInput, but it is overridden in all-packages.nix, which breaks splicing. Therefore, buildPackages.texinfo needs to be used explicitly in the override. This wasn't actually causing any problems because texinfo's scripts were using build platform Perl shebangs. Once texinfo was fixed, gpm started failing to cross-compile.
|
@ofborg build pkgsCross.armv7l-hf-multiplatform.texinfoInteractive |
ofborg
bot
added
10.rebuild-darwin-stdenv
Mindavi
added
the
6.topic: cross-compilation
trofi
approved these changes
Jun 23, 2022
| @@ -23224,7 +23224,7 @@ with pkgs; | |||
|
|
|||
| # latest 6.8 mysteriously fails to parse '@headings single': | |||
| # https://lists.gnu.org/archive/html/bug-texinfo/2021-09/msg00011.html | |||
| texinfo = texinfo6_7; | |||
| texinfo = buildPackages.texinfo6_7; | |||
There was a problem hiding this comment.
I wonder why this is needed. gpm seems to put texinfo into nativeBuildInputs. I would expect it to be enough.
bobby285271
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The XS modules were being built for the build platform, and the perl scripts had build platform shebangs.
It is possible to build the XS modules by passing
PERL_EXT_CC=${stdenv.cc.targetPrefix}cc --enable-perl-xs=yes, but theyfail to load due to a handshake key mismatch. Instead, I just decided to disable the XS modules and use the pure Perl fallbacks when cross-compiling.
The shebangs were fixed manually using
substituteInPlace.I also discovered that
gpmwas unintentionally relying on the incorrect shebangs, so I fixed that as well.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes